Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1168943002: Remove ContextProvider::IsContextLost. (Closed)

Created:
5 years, 6 months ago by danakj
Modified:
5 years, 6 months ago
Reviewers:
piman, boliu, sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, yzshen+watch_chromium.org, sievers+watch_chromium.org, ben+mojo_chromium.org, danakj+watch_chromium.org, jam, abarth-chromium, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, Ian Vollick, mcasas+watch_chromium.org, Aaron Boodman, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), wjia+watch_chromium.org, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContextProvider::IsContextLost. Use GLES2Interface::GetGraphicsResetStatusKHR() instead now that it exists. R=piman@chromium.org BUG=492447 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/6b2828ada942b5fab85bc8e1dbc61e63701693f9 Cr-Commit-Position: refs/heads/master@{#333578}

Patch Set 1 #

Patch Set 2 : contextprovider: . #

Patch Set 3 : contextprovider: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -76 lines) Patch
M android_webview/browser/aw_render_thread_context_provider.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/browser/aw_render_thread_context_provider.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M cc/output/context_provider.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/program_binding.h View 4 chunks +5 lines, -3 lines 0 comments Download
M cc/output/program_binding.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M cc/raster/tile_task_worker_pool_perftest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/test_context_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/test_context_provider.cc View 3 chunks +3 lines, -10 lines 0 comments Download
M cc/test/test_gles2_interface.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/test_gles2_interface.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M cc/test/test_in_process_context_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/test_in_process_context_provider.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/view_manager/surfaces/surfaces_context_provider.h View 2 chunks +0 lines, -2 lines 0 comments Download
M components/view_manager/surfaces/surfaces_context_provider.cc View 3 chunks +1 line, -7 lines 0 comments Download
M content/browser/android/in_process/context_provider_in_process.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/in_process/context_provider_in_process.cc View 1 chunk +1 line, -8 lines 0 comments Download
M content/common/gpu/client/context_provider_command_buffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/client/context_provider_command_buffer.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M content/renderer/gpu/mailbox_output_surface.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/media/renderer_gpu_video_accelerator_factories.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/cc/context_provider_mojo.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/cc/context_provider_mojo.cc View 3 chunks +1 line, -6 lines 0 comments Download
M ui/compositor/test/in_process_context_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/test/in_process_context_provider.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
danakj
5 years, 6 months ago (2015-06-08 23:14:45 UTC) #1
piman
lgtm
5 years, 6 months ago (2015-06-09 00:02:43 UTC) #2
danakj
+sky for mojo and components
5 years, 6 months ago (2015-06-09 00:50:31 UTC) #4
sky
LGTM
5 years, 6 months ago (2015-06-09 13:15:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168943002/1
5 years, 6 months ago (2015-06-09 16:52:59 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/31648)
5 years, 6 months ago (2015-06-09 17:34:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168943002/40001
5 years, 6 months ago (2015-06-09 20:20:07 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/69555)
5 years, 6 months ago (2015-06-09 20:28:36 UTC) #16
danakj
+boliu for android_webview/
5 years, 6 months ago (2015-06-09 20:30:22 UTC) #18
boliu
lgtm
5 years, 6 months ago (2015-06-09 20:31:09 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168943002/40001
5 years, 6 months ago (2015-06-09 20:32:17 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-09 21:39:46 UTC) #22
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 21:40:35 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6b2828ada942b5fab85bc8e1dbc61e63701693f9
Cr-Commit-Position: refs/heads/master@{#333578}

Powered by Google App Engine
This is Rietveld 408576698