runtime/vm/dart_entry.cc - Issue 1168933002: Fixes crashes in VM isolate shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_entry.cc

Issue 1168933002: Fixes crashes in VM isolate shutdown. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Add asserts Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/dart_entry.cc

diff --git a/runtime/vm/dart_entry.cc b/runtime/vm/dart_entry.cc

index 10c194bf8b265bdd7da6b422a6f62df679255c43..e708f409593320fb593ac92f5a331d7a0d139003 100644

--- a/runtime/vm/dart_entry.cc

+++ b/runtime/vm/dart_entry.cc

@@ -491,6 +491,7 @@ RawObject* DartLibraryCalls::HandleMessage(const Object& handler,

const Array& args = Array::Handle(isolate, Array::New(kNumArguments));

args.SetAt(0, handler);

args.SetAt(1, message);

+ ASSERT(isolate->debugger() != NULL);

if (isolate->debugger()->IsStepping()) {

// If the isolate is being debugged and the debugger was stepping

// through code, enable single stepping so debugger will stop