runtime/vm/dart_api_impl.cc - Issue 1168933002: Fixes crashes in VM isolate shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 1168933002: Fixes crashes in VM isolate shutdown. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Add asserts Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/dart_api_impl.cc

diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc

index 9562941a55c1c60df280fc5fbc503b0682092fa2..f2fc08cb98d9e954d8ab90638c0d3d923818113e 100644

--- a/runtime/vm/dart_api_impl.cc

+++ b/runtime/vm/dart_api_impl.cc

@@ -5492,6 +5492,7 @@ DART_EXPORT Dart_Handle Dart_FinalizeLoading(bool complete_futures) {

// the new code, the debugger convert them to unresolved source breakpoints.

// The code that completes the futures (invoked below) may call into the

// newly loaded code and trigger one of these breakpoints.

+ ASSERT(isolate->debugger() != NULL);

isolate->debugger()->NotifyDoneLoading();

// Notify mirrors that MirrorSystem.libraries needs to be recomputed.