Oilpan: Introduce WeakProcessingVisitor

Source/platform/heap/ThreadState.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 18 matching lines @@
  */
 
 #include "config.h"
 #include "platform/heap/ThreadState.h"
 
 #include "platform/ScriptForbiddenScope.h"
 #include "platform/TraceEvent.h"
 #include "platform/heap/CallbackStack.h"
 #include "platform/heap/Handle.h"
 #include "platform/heap/Heap.h"
+#include "platform/heap/MarkingVisitor.h"
 #include "platform/heap/SafePoint.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebScheduler.h"
 #include "public/platform/WebThread.h"
 #include "public/platform/WebTraceLocation.h"
 #include "wtf/Partitions.h"
 #include "wtf/ThreadingPrimitives.h"
 #if ENABLE(GC_PROFILING)
 #include "platform/TracedValue.h"
 #include "wtf/text/StringHash.h"
@@ skipping 845 matching lines @@
     checkThread();
     if (gcState() != EagerSweepScheduled && gcState() != LazySweepScheduled)
         return;
 
     {
         if (isMainThread())
             ScriptForbiddenScope::enter();
 
         SweepForbiddenScope forbiddenScope(this);
         {
+            MarkingVisitor<Visitor::WeakProcessing> weakProcessingVisitor;
+
             // Disallow allocation during weak processing.
             NoAllocationScope noAllocationScope(this);
             {
                 // Perform thread-specific weak processing.
                 TRACE_EVENT0("blink_gc", "ThreadState::threadLocalWeakProcessing");
-                // TODO(haraken): It is wrong to unconditionally use
-                // s_markingVisitor, which is for GlobalMarking.
-                // ThreadTerminationGC should use a visitor for
-                // ThreadLocalMarking. However, a better fix is just to remove
-                // the visitor parameter. The only user of the visitor parameter
-                // is HashTable::process.
-                while (popAndInvokeThreadLocalWeakCallback(Heap::s_markingVisitor)) { }
+                while (popAndInvokeThreadLocalWeakCallback(&weakProcessingVisitor)) { }
             }
             {
                 TRACE_EVENT0("blink_gc", "ThreadState::invokePreFinalizers");
                 invokePreFinalizers();
             }
         }
 
         if (isMainThread())
             ScriptForbiddenScope::exit();
     }
@@ skipping 457 matching lines @@
         json->beginArray(it->key.ascii().data());
         for (size_t age = 0; age <= maxHeapObjectAge; ++age)
             json->pushInteger(it->value.ages[age]);
         json->endArray();
     }
     TRACE_EVENT_OBJECT_SNAPSHOT_WITH_ID(TRACE_DISABLED_BY_DEFAULT("blink_gc"), statsName, this, json.release());
 }
 #endif
 
 } // namespace blink