Make swarming work w/ GN (kinda)

base/BUILD.gn

Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index d075e1eb37d9f6d2b6f32fe30c978dc4dbf50bb2..1661bf5a2a77f2981f1d1a69a72be0d59506adc5 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -1316,6 +1316,12 @@ test("base_unittests") {
     "//third_party/icu",
   ]
 
+  # TODO(dpranke): Replace this with a better form of globbing or
+  # some other way to indicate that we depend on the contents of a directory.
+  data = exec_script("//build/android/gyp/find.py",
+                     [ rebase_path("test/data") ],
+                     "list lines")

[Dirk Pranke, 2015/06/03 02:24:54]

This is a hack; it is the equivalent of specifying "test/data/" in
base_unittest.isolate.

At the moment GN requires data to be a list of source files, and gets really
confused if you hand it a directory. We could make this slightly less of a hack
by adding in a built-in glob() function, but it might be better to create a
separate 'data_dirs' key or change 'data' to be a list of paths instead.

Brett, thoughts?

[M-A Ruel, 2015/06/03 15:47:18]

isolate really needs to be passed a directory, because often the directory is in
PRODUCT_DIR, so enumerating at GN time will not return the files, they do not
exist yet.

[Dirk Pranke, 2015/06/03 17:15:49]

Yeah, it occurred to me that it would be fragile even in the normal case, since
we wouldn't necessarily know when to re-run GN if the list of files changed.

+
   # Allow more direct string conversions on platforms with native utf8
   # strings
   if (is_mac || is_ios || is_chromeos) {