Make swarming work w/ GN (kinda)

base/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/ui.gni")
 import("//testing/test.gni")
 
 if (is_android) {
   import("//build/config/android/rules.gni")
 }
@@ skipping 1298 matching lines @@
     "//base/allocator",
     "//base/test:run_all_unittests",
     "//base/test:test_support",
     "//base/third_party/dynamic_annotations",
     "//base/trace_event:trace_event_unittests",
     "//testing/gmock",
     "//testing/gtest",
     "//third_party/icu",
   ]
 
+  # TODO(dpranke): Replace this with a better form of globbing or
+  # some other way to indicate that we depend on the contents of a directory.
+  data = exec_script("//build/android/gyp/find.py",
+                     [ rebase_path("test/data") ],
+                     "list lines")

[Dirk Pranke, 2015/06/03 02:24:54]

This is a hack; it is the equivalent of specifying "test/data/" in
base_unittest.isolate.

At the moment GN requires data to be a list of source files, and gets really
confused if you hand it a directory. We could make this slightly less of a hack
by adding in a built-in glob() function, but it might be better to create a
separate 'data_dirs' key or change 'data' to be a list of paths instead.

Brett, thoughts?

[M-A Ruel, 2015/06/03 15:47:18]

isolate really needs to be passed a directory, because often the directory is in
PRODUCT_DIR, so enumerating at GN time will not return the files, they do not
exist yet.

[Dirk Pranke, 2015/06/03 17:15:49]

Yeah, it occurred to me that it would be fragile even in the normal case, since
we wouldn't necessarily know when to re-run GN if the list of files changed.

+
   # Allow more direct string conversions on platforms with native utf8
   # strings
   if (is_mac || is_ios || is_chromeos) {
     defines = [ "SYSTEM_NATIVE_UTF8" ]
   }
 
   if (is_android) {
     apk_deps = [
       ":base_java",
       ":base_java_unittest_support",
@@ skipping 174 matching lines @@
 
   # GYP: //base.gyp:base_java_unittest_support
   android_library("base_java_unittest_support") {
     deps = [
       ":base_java",
     ]
     java_files =
         [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ]
   }
 }