Source/core/css/parser/CSSPropertyParser.h - Issue 1168453002: [CSSGridLayout] Switch from parentheses to brackets for grid line names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSPropertyParser.h

Issue 1168453002: [CSSGridLayout] Switch from parentheses to brackets for grid line names (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed test and parsing Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/css/CSSGridLineNamesValue.cpp ('k') | Source/core/css/parser/CSSPropertyParser.cpp » ('j') | Source/core/css/parser/CSSPropertyParser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/parser/CSSPropertyParser.h

diff --git a/Source/core/css/parser/CSSPropertyParser.h b/Source/core/css/parser/CSSPropertyParser.h

index e9d0c5cb8ba48731ef598980d4b906de7b26993c..6d729248e800ac921dc8bf813160655d926572a7 100644

--- a/Source/core/css/parser/CSSPropertyParser.h

+++ b/Source/core/css/parser/CSSPropertyParser.h

@@ -167,7 +167,7 @@ private:

PassRefPtrWillBeRawPtr<CSSPrimitiveValue> parseGridBreadth(CSSParserValue*);

bool parseGridTemplateAreasRow(NamedGridAreaMap&, const size_t, size_t&);

PassRefPtrWillBeRawPtr<CSSValue> parseGridTemplateAreas();

- void maybeParseGridLineNames(CSSParserValueList&, CSSValueList&, CSSGridLineNamesValue* = 0);

+ bool maybeParseGridLineNames(CSSParserValueList&, CSSValueList&, CSSGridLineNamesValue* = nullptr);

PassRefPtrWillBeRawPtr<CSSValue> parseGridAutoFlow(CSSParserValueList&);

PassRefPtrWillBeRawPtr<CSSPrimitiveValue> parseClipShape();

« no previous file with comments | « Source/core/css/CSSGridLineNamesValue.cpp ('k') | Source/core/css/parser/CSSPropertyParser.cpp » ('j') | Source/core/css/parser/CSSPropertyParser.cpp » ('J')