Source/core/css/CSSGridLineNamesValue.cpp - Issue 1168453002: [CSSGridLayout] Switch from parentheses to brackets for grid line names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSGridLineNamesValue.cpp

Issue 1168453002: [CSSGridLayout] Switch from parentheses to brackets for grid line names (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed test and parsing Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/resources/non-grid-columns-rows-get-set-multiple.js ('k') | Source/core/css/parser/CSSPropertyParser.h » ('j') | Source/core/css/parser/CSSPropertyParser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/CSSGridLineNamesValue.cpp

diff --git a/Source/core/css/CSSGridLineNamesValue.cpp b/Source/core/css/CSSGridLineNamesValue.cpp

index 3d24511f69a3aef4555593583fae122fe8c8c245..c60421f838a8e8c80363d137d1af9a196934124a 100644

--- a/Source/core/css/CSSGridLineNamesValue.cpp

+++ b/Source/core/css/CSSGridLineNamesValue.cpp

@@ -35,7 +35,7 @@ namespace blink {

String CSSGridLineNamesValue::customCSSText() const

{

- return "(" + CSSValueList::customCSSText() + ")";

+ return "[" + CSSValueList::customCSSText() + "]";

}

CSSGridLineNamesValue::CSSGridLineNamesValue()