Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1168423002: DevTools: merge InjectedScriptBase into InjectedScript (Closed)

Created:
5 years, 6 months ago by yurys
Modified:
5 years, 6 months ago
Reviewers:
alph, sergeyv, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: merge InjectedScriptBase into InjectedScript Canvas profiler that was implemented as a module of injected script was dropped. We don't want to support injected script modules in such form so the base class doesn't make sense anymore. BUG=475808 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196769

Patch Set 1 #

Patch Set 2 : typedef -> using #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -326 lines) Patch
M Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InjectedScript.h View 1 3 chunks +25 lines, -3 lines 0 comments Download
M Source/core/inspector/InjectedScript.cpp View 3 chunks +187 lines, -2 lines 0 comments Download
D Source/core/inspector/InjectedScriptBase.h View 1 chunk +0 lines, -81 lines 0 comments Download
D Source/core/inspector/InjectedScriptBase.cpp View 1 chunk +0 lines, -238 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
yurys
5 years, 6 months ago (2015-06-09 12:54:06 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168423002/20001
5 years, 6 months ago (2015-06-09 12:54:20 UTC) #4
yurys
5 years, 6 months ago (2015-06-09 13:17:37 UTC) #6
alph
lgtm
5 years, 6 months ago (2015-06-09 13:36:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168423002/20001
5 years, 6 months ago (2015-06-09 13:41:53 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 14:52:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196769

Powered by Google App Engine
This is Rietveld 408576698