Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1168393008: Revert of Revert of [es6] Parsing of new.target (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Revert of [es6] Parsing of new.target (patchset #1 id:1 of https://codereview.chromium.org/1170263002/) Reason for revert: The bot needs to be clobbered. Original issue's description: > Revert of [es6] Parsing of new.target (patchset #2 id:20001 of https://codereview.chromium.org/1169853002/) > > Reason for revert: > [Sheriff] fails messages: > http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20custom%20snapshot%20-%20debug/builds/1703 > > Original issue's description: > > [es6] Parsing of new.target > > > > BUG=v8:3887 > > LOG=N > > R=adamk@chromium.org, dslomov@chromium.org > > > > Committed: https://crrev.com/ae06bdde7763d673b39948b710df414217265cce > > Cr-Commit-Position: refs/heads/master@{#28865} > > TBR=adamk@chromium.org,dslomov@chromium.org,arv@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3887 > > Committed: https://crrev.com/fe97cfccf3faabbeff87b9b5fbacd7ceb8219304 > Cr-Commit-Position: refs/heads/master@{#28868} TBR=adamk@chromium.org,dslomov@chromium.org,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3887 Committed: https://crrev.com/b1c7340275b467e490a98d892f0b401eb2369553 Cr-Commit-Position: refs/heads/master@{#28870}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -89 lines) Patch
M src/bootstrapper.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/parser.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/parser.cc View 4 chunks +28 lines, -20 lines 0 comments Download
M src/preparser.h View 9 chunks +64 lines, -67 lines 0 comments Download
M src/preparser.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 3 chunks +57 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
arv (Not doing code reviews)
Created Revert of Revert of [es6] Parsing of new.target
5 years, 6 months ago (2015-06-09 15:42:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168393008/1
5 years, 6 months ago (2015-06-09 15:42:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-09 15:43:19 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 15:43:26 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1c7340275b467e490a98d892f0b401eb2369553
Cr-Commit-Position: refs/heads/master@{#28870}

Powered by Google App Engine
This is Rietveld 408576698