Issue 1168323003: Make ink splashes work in MenuItem

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1168323003: Make ink splashes work in MenuItem (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie, eseidel

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make ink splashes work in MenuItem Previously, the ink splashes would disappear immediately because the button highlight would change the structure of the component hierarchy and we weren't smart enough to retain the underlying RenderInkSplash. This CL is a point fix for that issue by avoiding changing the structure of the component hierarchy. A more complete fix would be to make Container smarter about how it syncs its subcomponents. R=eseidel@chromium.org, ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/f998f7e0c34d7f90960fc2a630ad158a87cdce50

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -7 lines)			Patch
	M	sky/sdk/lib/framework/components2/menu_item.dart	View		2 chunks	+15 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

5 years, 6 months ago (2015-06-10 16:23:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f998f7e0c34d7f90960fc2a630ad158a87cdce50 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages