Make ink splashes work in MenuItem

sky/sdk/lib/framework/components2/menu_item.dart

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 import '../fn2.dart';
 import 'button_base.dart';
 import 'icon.dart';
 import 'ink_well.dart';
 
+const BoxDecoration _kHighlightDecoration = const BoxDecoration(
+  backgroundColor: const Color.fromARGB(102, 153, 153, 153)
+);
+
+// TODO(abarth): We shouldn't need _kHighlightBoring, but currently Container
+//               isn't smarth enough to retain the components it builds when we
+//               add or remove a |decoration|. For now, we use a transparent
+//               decoration to avoid changing the structure of the tree. The
+//               right fix, however, is to make Container smarter about how it
+//               syncs its subcomponents.
+const BoxDecoration _kHighlightBoring = const BoxDecoration(
+  backgroundColor: const Color.fromARGB(0, 0, 0, 0)
+);
+
 class MenuItem extends ButtonBase {
-
   MenuItem({ Object key, this.icon, this.children, this.onGestureTap }) : super(key: key);
 
-  static const BoxDecoration highlightDecoration = const BoxDecoration(
-    backgroundColor: const Color.fromARGB(102, 153, 153, 153)
-  );
-
   List<UINode> children;
   String icon;
   GestureEventListener onGestureTap;
 
   UINode buildContent() {
     return new EventListenerNode(
       new Container(
         child: new InkWell(
           children: [
             new Padding(
               child: new Icon(type: "${icon}_grey600", size: 24),
               padding: const EdgeDims.symmetric(horizontal: 16.0)
             ),
             new FlexExpandingChild(
               new Padding(
                 child: new FlexContainer(
                   direction: FlexDirection.horizontal,
                   children: children
                 ),
                 padding: const EdgeDims.symmetric(horizontal: 16.0)
               ),
               flex: 1
             )
           ]
         ),
         height: 48.0,
-        decoration: highlight ? highlightDecoration : null
+        decoration: highlight ? _kHighlightDecoration : _kHighlightBoring
       ),
       onGestureTap: onGestureTap
     );
   }
-
 }