Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1168303007: [test] Refactoring - Let runner handle test IDs. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Refactoring - Let runner handle test IDs. This prepares for properly rerunning tests. Currently when tests are rerun, the same test object is reused. This will be changed in a follow up. Committed: https://crrev.com/f41a81b8a513fc360c500c066b74f223bc9c0223 Cr-Commit-Position: refs/heads/master@{#28864}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M tools/run-tests.py View 2 chunks +0 lines, -4 lines 0 comments Download
M tools/testrunner/local/execution.py View 2 chunks +9 lines, -4 lines 0 comments Download
M tools/testrunner/network/network_execution.py View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Michael Achenbach
PTAL
5 years, 6 months ago (2015-06-09 13:45:15 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168303007/1
5 years, 6 months ago (2015-06-09 13:45:27 UTC) #4
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-06-09 13:48:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168303007/1
5 years, 6 months ago (2015-06-09 14:11:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-09 14:17:11 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f41a81b8a513fc360c500c066b74f223bc9c0223 Cr-Commit-Position: refs/heads/master@{#28864}
5 years, 6 months ago (2015-06-09 14:17:16 UTC) #10
Michael Achenbach
5 years, 6 months ago (2015-06-10 06:46:20 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1167343003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Revert until the tree is in a better
state..

Powered by Google App Engine
This is Rietveld 408576698