Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1168223002: Fix for issue 23598, add a Dart_CreateLibrarySnapshot entrypoint to the API. (Closed)

Created:
5 years, 6 months ago by siva
Modified:
5 years, 6 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for issue 23598, add a Dart_CreateLibrarySnapshot entrypoint to the API. BUG=23598 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/c67f93099fa3ac3e6a80e08517c16fe0df842806

Patch Set 1 #

Total comments: 4

Patch Set 2 : address code review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -10 lines) Patch
M runtime/include/dart_api.h View 1 chunk +21 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 chunks +22 lines, -9 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 2 chunks +45 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
siva
5 years, 6 months ago (2015-06-08 21:58:03 UTC) #2
Cutch
LGTM with one suggestion. https://codereview.chromium.org/1168223002/diff/1/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/1168223002/diff/1/runtime/vm/dart_api_impl.cc#newcode1496 runtime/vm/dart_api_impl.cc:1496: if (library == NULL) { ...
5 years, 6 months ago (2015-06-08 23:00:52 UTC) #4
siva
https://codereview.chromium.org/1168223002/diff/1/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/1168223002/diff/1/runtime/vm/dart_api_impl.cc#newcode1496 runtime/vm/dart_api_impl.cc:1496: if (library == NULL) { On 2015/06/08 23:00:51, Cutch ...
5 years, 6 months ago (2015-06-09 00:49:21 UTC) #5
siva
5 years, 6 months ago (2015-06-09 01:05:21 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
c67f93099fa3ac3e6a80e08517c16fe0df842806 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698