gpu: Make sure we restore scissor rect after clearing a texture level.

gpu: Make sure we restore scissor rect after clearing a texture level.

BUG=460288
TEST=gpu_unittests

Committed: https://crrev.com/842a0983ef88f1dd426fb841e90e3c180455288f
Cr-Commit-Position: refs/heads/master@{#333451}

[reveman, 2015-06-09 02:29:56]

reveman@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2015-06-09 02:42:52]

lgtm

[Ken Russell (switch to Gerrit), 2015-06-09 02:46:19]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2015-06-09 02:46:20]

Non-owner thumbs up. One comment.

https://codereview.chromium.org/1168213003/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc
(right):

https://codereview.chromium.org/1168213003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc:1806: //
the clear, then disable it and restore the rect again.
It looks to me like we've lost a test where we go into the clear with the
scissor test enabled and a particular scissor rect set, and ensure that after
the clear the scissor test is still enabled and the scissor rect is unmodified.

[reveman, 2015-06-09 03:07:37]

https://codereview.chromium.org/1168213003/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc
(right):

https://codereview.chromium.org/1168213003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc:1806: //
the clear, then disable it and restore the rect again.
On 2015/06/09 at 02:46:19, Ken Russell wrote:
> It looks to me like we've lost a test where we go into the clear with the
scissor test enabled and a particular scissor rect set, and ensure that after
the clear the scissor test is still enabled and the scissor rect is unmodified.

Made the UnClearedAttachmentsGetClearedOnClear test go into the clear with the
scissor test enabled in latest patch.

[reveman, 2015-06-09 03:07:49]

The CQ bit was checked by reveman@chromium.org

[reveman, 2015-06-09 03:07:50]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1168213003/#ps20001
(title: "enable scissor test in UnClearedAttachmentsGetClearedOnClear")

[commit-bot: I haz the power, 2015-06-09 03:08:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1168213003/20001

[commit-bot: I haz the power, 2015-06-09 05:14:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-09 05:16:17]

Patchset 2 (id:??) landed as
https://crrev.com/842a0983ef88f1dd426fb841e90e3c180455288f
Cr-Commit-Position: refs/heads/master@{#333451}