cr: Ensure build directory exists before writing gn args

cr: Ensure build directory exists before writing gn args

BUG=496616
Committed: https://crrev.com/60d210bdb116e0fb107714ed4c1ec0105f07a257
Cr-Commit-Position: refs/heads/master@{#333255}

[Sami, 2015-06-08 09:34:06]

skyostil@chromium.org changed reviewers:
+ petrcermak@chromium.org

[petrcermak, 2015-06-08 09:41:55]

LGTM.

Thanks,
Petr

https://codereview.chromium.org/1168053003/diff/1/tools/cr/cr/actions/gn.py
File tools/cr/cr/actions/gn.py (right):

https://codereview.chromium.org/1168053003/diff/1/tools/cr/cr/actions/gn.py#n...
tools/cr/cr/actions/gn.py:82: os.makedirs(out_path)
FYI: We do the following in tools/cr/cr/base/client.py instead:

  try:
    os.makedirs(out_path)
  except OSError:
    if not os.path.isdir(out_path):
      raise

[Sami, 2015-06-08 09:53:28]

Thanks Petr!

https://codereview.chromium.org/1168053003/diff/1/tools/cr/cr/actions/gn.py
File tools/cr/cr/actions/gn.py (right):

https://codereview.chromium.org/1168053003/diff/1/tools/cr/cr/actions/gn.py#n...
tools/cr/cr/actions/gn.py:82: os.makedirs(out_path)
On 2015/06/08 09:41:55, petrcermak wrote:
> FYI: We do the following in tools/cr/cr/base/client.py instead:
> 
>   try:
>     os.makedirs(out_path)
>   except OSError:
>     if not os.path.isdir(out_path):
>       raise

Ah, right, that works too. Done.

[Sami, 2015-06-08 09:53:34]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2015-06-08 09:53:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
petrcermak@chromium.org
Link to the patchset: https://codereview.chromium.org/1168053003/#ps20001
(title: "Review comments.")

[commit-bot: I haz the power, 2015-06-08 09:53:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1168053003/20001

[commit-bot: I haz the power, 2015-06-08 10:01:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-08 10:02:24]

Patchset 2 (id:??) landed as
https://crrev.com/60d210bdb116e0fb107714ed4c1ec0105f07a257
Cr-Commit-Position: refs/heads/master@{#333255}