tools/cr/cr/actions/gn.py - Issue 1168053003: cr: Ensure build directory exists before writing gn args

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/cr/cr/actions/gn.py

Issue 1168053003: cr: Ensure build directory exists before writing gn args (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/cr/cr/actions/gn.py

diff --git a/tools/cr/cr/actions/gn.py b/tools/cr/cr/actions/gn.py

index a79aa81fc24d2a6aded7fe8ab7577363d2909b7d..fcd40c766aa72c21ccc4e19b73962b32a053a7a2 100644

--- a/tools/cr/cr/actions/gn.py

+++ b/tools/cr/cr/actions/gn.py

@@ -78,6 +78,11 @@ class GnPrepareOut(cr.PrepareOut):

for key, value in args.items():

arg_lines.append('%s = %s' % (key, value))

+ try:

+ os.makedirs(out_path)

+ except OSError:

+ if not os.path.isdir(out_path):

+ raise

with open(args_file, 'w') as f:

f.write('\n'.join(arg_lines) + '\n')

« no previous file with comments | « no previous file | no next file » | no next file with comments »