Issue 1167873003: Oilpan: avoid creating a cyclic reference to InjectedScriptHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1167873003: Oilpan: avoid creating a cyclic reference to InjectedScriptHost. (Closed)

Created:
5 years, 6 months ago by sof

Modified:
5 years, 6 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, caseq+blink_chromium.org, arv+blink, vivekg_samsung, vivekg, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: avoid creating a cyclic reference to InjectedScriptHost. Follow up r196524 and keep a raw back pointer to InjectedScriptHost instead of a Persistent, as that will create a cycle by way of the v8 heap. InjectedScriptHost will outlive the WeakCallbackData that keeps the back reference, so safe. InjectedScriptHost is also slated for removal from the Oilpan heap. R=haraken BUG=46631 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196572

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	Source/bindings/core/v8/inspector/V8InjectedScriptHost.cpp	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167873003/1

5 years, 6 months ago (2015-06-05 13:19:11 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-05 13:22:19 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196572

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages