Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: Source/bindings/core/v8/inspector/V8InjectedScriptHost.cpp

Issue 1167873003: Oilpan: avoid creating a cyclic reference to InjectedScriptHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/inspector/V8InjectedScriptHost.cpp
diff --git a/Source/bindings/core/v8/inspector/V8InjectedScriptHost.cpp b/Source/bindings/core/v8/inspector/V8InjectedScriptHost.cpp
index 15bda4aa16bbb20fb4bef375f6db038a1b46f087..2288ef8ea173a31d2d5f240f8fb75936f807dc4a 100644
--- a/Source/bindings/core/v8/inspector/V8InjectedScriptHost.cpp
+++ b/Source/bindings/core/v8/inspector/V8InjectedScriptHost.cpp
@@ -633,7 +633,11 @@ public:
m_persistent.SetWeak(this, &WeakCallbackData::weakCallback, v8::WeakCallbackType::kParameter);
}
- RefPtrWillBePersistent<InjectedScriptHost> m_host;
+ // If kept as a strong Persistent<>, this back reference causes an Oilpan leak by
+ // way of v8. Sidestep by using a raw pointer; InjectedScriptHost is slated to
+ // become a non-Oilpan object.
+ GC_PLUGIN_IGNORE("466631")
+ RefPtrWillBeRawPtr<InjectedScriptHost> m_host;
private:
static void weakCallback(const v8::WeakCallbackInfo<WeakCallbackData>& info)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698