[date] Refactor the %_DateField intrinsic to be optimizable.

[date] Refactor the %_DateField intrinsic to be optimizable.

Previously the %_DateField intrinsic would also check the object and
throw an exception if you happen to pass something that is not a valid
JSDate, which (a) violates our policy for instrinsics and (b) is hard to
optimize in TurboFan (even Crankshaft has a hard time, but there we will
never inline the relevant builtins, so it doesn't show up). The throwing
part is now a separate intrinsics %_ThrowIfNotADate that throws an
exception in full codegen and deoptimizes in Crankshaft, which means the
code for the current use cases is roughly the same (modulo some register
renamings/gap moves).

R=jkummerow@chromium.org

Committed: https://crrev.com/e4782a9b468258344d512a5f7dadbf1584928849
Cr-Commit-Position: refs/heads/master@{#28782}

[Benedikt Meurer, 2015-06-03 07:10:29]

Hey Jakob,

This is the CL I mentioned to cleanup the date checking. Please take a look.

Thanks,
Benedikt

[Jakob Kummerow, 2015-06-03 08:01:26]

lgtm

https://codereview.chromium.org/1167813003/diff/1/src/ia32/lithium-codegen-ia...
File src/ia32/lithium-codegen-ia32.cc (left):

https://codereview.chromium.org/1167813003/diff/1/src/ia32/lithium-codegen-ia...
src/ia32/lithium-codegen-ia32.cc:1793: Label runtime, done;
nit: for consistency, move this into the smaller scope below? Same on arm and
mips.

[Benedikt Meurer, 2015-06-03 08:04:29]

Nit addressed, thanks.

https://codereview.chromium.org/1167813003/diff/1/src/ia32/lithium-codegen-ia...
File src/ia32/lithium-codegen-ia32.cc (left):

https://codereview.chromium.org/1167813003/diff/1/src/ia32/lithium-codegen-ia...
src/ia32/lithium-codegen-ia32.cc:1793: Label runtime, done;
On 2015/06/03 08:01:26, Jakob wrote:
> nit: for consistency, move this into the smaller scope below? Same on arm and
> mips.

Done.

[Benedikt Meurer, 2015-06-03 08:04:35]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-06-03 08:04:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1167813003/#ps40001
(title: "Address comments.")

[commit-bot: I haz the power, 2015-06-03 08:04:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1167813003/40001

[commit-bot: I haz the power, 2015-06-03 08:31:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-03 08:31:36]

Patchset 3 (id:??) landed as
https://crrev.com/e4782a9b468258344d512a5f7dadbf1584928849
Cr-Commit-Position: refs/heads/master@{#28782}