src/arm/lithium-arm.cc - Issue 1167813003: [date] Refactor the %_DateField intrinsic to be optimizable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/lithium-arm.cc

Issue 1167813003: [date] Refactor the %_DateField intrinsic to be optimizable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/lithium-arm.cc

diff --git a/src/arm/lithium-arm.cc b/src/arm/lithium-arm.cc

index d8cc7e5a9fc9c736bf684d1db7529fb7c428ada8..4ee73e851abd5e8b5e6d893c1435a219b378c7cf 100644

--- a/src/arm/lithium-arm.cc

+++ b/src/arm/lithium-arm.cc

@@ -1855,7 +1855,7 @@ LInstruction* LChunkBuilder::DoDateField(HDateField* instr) {

LOperand* object = UseFixed(instr->value(), r0);

LDateField* result =

new(zone()) LDateField(object, FixedTemp(r1), instr->index());

- return MarkAsCall(DefineFixed(result, r0), instr, CAN_DEOPTIMIZE_EAGERLY);

+ return MarkAsCall(DefineFixed(result, r0), instr, CANNOT_DEOPTIMIZE_EAGERLY);

}

« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »