Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1167753003: Revert of win: Fix current toolchain path with old packaging (Closed)

Created:
5 years, 6 months ago by scottmg
Modified:
5 years, 6 months ago
Reviewers:
Dirk Pranke, davidben
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Revert of win: Fix current toolchain path with old packaging (patchset #1 id:1 of https://codereview.chromium.org/1159433006/) Reason for revert: Breaking chromium waterfall. Original issue's description: > win: Fix current toolchain path with old packaging > > I broke boringssl's use of depot_tools toolchain as I changed the > name of the sdk path key. This happened to work in Chrome because > src/ has fallback behaviour. > > Restore the 'win8sdk' name when unpacking a current/old-style > toolchain package (i.e. what everyone is still using). > > TBR=dpranke@chromium.org > R=davidben@chromium.org > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295492 TBR=davidben@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295493

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M win_toolchain/get_toolchain_if_necessary.py View 2 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
Created Revert of win: Fix current toolchain path with old packaging
5 years, 6 months ago (2015-06-02 19:37:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167753003/1
5 years, 6 months ago (2015-06-02 19:37:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=295493
5 years, 6 months ago (2015-06-02 19:37:47 UTC) #3
Dirk Pranke
5 years, 6 months ago (2015-06-02 19:39:02 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698