Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Unified Diff: win_toolchain/get_toolchain_if_necessary.py

Issue 1167753003: Revert of win: Fix current toolchain path with old packaging (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: win_toolchain/get_toolchain_if_necessary.py
diff --git a/win_toolchain/get_toolchain_if_necessary.py b/win_toolchain/get_toolchain_if_necessary.py
index 5bda1eecc2c25f4e27073ed85da6d4ff66022686..cb4b5da2c64e02936fae53d237b4ed9ea130bb1d 100755
--- a/win_toolchain/get_toolchain_if_necessary.py
+++ b/win_toolchain/get_toolchain_if_necessary.py
@@ -290,16 +290,7 @@
got_new_toolchain = True
- data = {
- 'path': abs_target_dir,
- 'win_sdk': os.path.join(abs_target_dir, 'win_sdk'),
- 'wdk': os.path.join(abs_target_dir, 'wdk'),
- 'runtime_dirs': [
- os.path.join(abs_target_dir, 'sys64'),
- os.path.join(abs_target_dir, 'sys32'),
- ],
- }
-
+ win_sdk = os.path.join(abs_target_dir, 'win_sdk')
try:
with open(os.path.join(target_dir, 'VS_VERSION'), 'rb') as f:
vs_version = f.read().strip()
@@ -307,10 +298,18 @@
# Older toolchains didn't have the VS_VERSION file, and used 'win8sdk'
# instead of just 'win_sdk'.
vs_version = '2013'
- data['win8sdk'] = os.path.join(abs_target_dir, 'win8sdk')
-
- data['version'] = vs_version
-
+ win_sdk = os.path.join(abs_target_dir, 'win8sdk')
+
+ data = {
+ 'path': abs_target_dir,
+ 'version': vs_version,
+ 'win_sdk': win_sdk,
+ 'wdk': os.path.join(abs_target_dir, 'wdk'),
+ 'runtime_dirs': [
+ os.path.join(abs_target_dir, 'sys64'),
+ os.path.join(abs_target_dir, 'sys32'),
+ ],
+ }
with open(os.path.join(target_dir, '..', 'data.json'), 'w') as f:
json.dump(data, f)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698