Issue 11677008: Account for unmanaged (e.g, WebGL) use in memory manager

Issue 11677008: Account for unmanaged (e.g, WebGL) use in memory manager (Closed)

Created:
7 years, 12 months ago by ccameron

Modified:
7 years, 11 months ago

Reviewers:
greggman, Zhenyao Mo, apatrick_chromium

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Account for unmanaged (e.g, WebGL) use in memory manager Set an interval of memory for unmanaged memory, and when memory usage leaves this interval, re-assign GPU memory budgets. Use this interval approach to avoid thrashing minute changes in policy. BUG=167693 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174864

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Resolve against head #

Total comments: 4

Patch Set 4 : Fix indentation #

Patch Set 5 : Incorporate review feedback #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+134 lines, -5 lines)			Patch
M	content/common/gpu/gpu_memory_manager.h	View	1	5 chunks	+24 lines, -0 lines	0 comments	Download
M	content/common/gpu/gpu_memory_manager.cc	View	1 2 3	8 chunks	+51 lines, -5 lines	0 comments	Download
M	content/common/gpu/gpu_memory_manager_unittest.cc	View	1	2 chunks	+59 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

apatrick_chromium

lgtm https://codereview.chromium.org/11677008/diff/4001/content/common/gpu/gpu_memory_manager.cc File content/common/gpu/gpu_memory_manager.cc (right): https://codereview.chromium.org/11677008/diff/4001/content/common/gpu/gpu_memory_manager.cc#newcode40 content/common/gpu/gpu_memory_manager.cc:40: return ((n + mul - 1) / mul) ...

7 years, 11 months ago (2013-01-02 19:04:40 UTC) #2

ccameron

Thanks!! https://codereview.chromium.org/11677008/diff/4001/content/common/gpu/gpu_memory_manager.cc File content/common/gpu/gpu_memory_manager.cc (right): https://codereview.chromium.org/11677008/diff/4001/content/common/gpu/gpu_memory_manager.cc#newcode40 content/common/gpu/gpu_memory_manager.cc:40: return ((n + mul - 1) / mul) ...

7 years, 11 months ago (2013-01-02 19:19:49 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/11677008/10001

7 years, 11 months ago (2013-01-02 19:20:11 UTC) #4

Message was sent while issue was closed.

Change committed as 174864

Expand Messages | Collapse Messages