Source/core/page/CreateWindow.cpp - Issue 1167653007: Cleanup: Rename ChromeClient::setWindowRect and setWindowRectInternal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/CreateWindow.cpp

Issue 1167653007: Cleanup: Rename ChromeClient::setWindowRect and setWindowRectInternal. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/CreateWindow.cpp

diff --git a/Source/core/page/CreateWindow.cpp b/Source/core/page/CreateWindow.cpp

index 12ff185467c0787e0401086af7a8c34c2d0aa3ef..36c57589d86a779e3ab7f1e4a508f8c89090d457 100644

--- a/Source/core/page/CreateWindow.cpp

+++ b/Source/core/page/CreateWindow.cpp

@@ -110,7 +110,7 @@ static Frame* createWindow(LocalFrame& openerFrame, LocalFrame& lookupFrame, con

if (features.heightSet)

windowRect.setHeight(features.height + (windowRect.height() - viewportSize.height()));

- host->chromeClient().setWindowRect(windowRect);

+ host->chromeClient().setWindowRectWithAdjustment(windowRect);

host->chromeClient().show(policy);

// TODO(japhet): There's currently no way to set sandbox flags on a RemoteFrame and have it propagate

« no previous file with comments | « Source/core/page/ChromeClient.cpp ('k') | Source/web/ChromeClientImpl.h » ('j') | no next file with comments »