Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: Source/core/page/CreateWindow.cpp

Issue 1167653007: Cleanup: Rename ChromeClient::setWindowRect and setWindowRectInternal. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/page/ChromeClient.cpp ('k') | Source/web/ChromeClientImpl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 103
104 if (features.xSet) 104 if (features.xSet)
105 windowRect.setX(features.x); 105 windowRect.setX(features.x);
106 if (features.ySet) 106 if (features.ySet)
107 windowRect.setY(features.y); 107 windowRect.setY(features.y);
108 if (features.widthSet) 108 if (features.widthSet)
109 windowRect.setWidth(features.width + (windowRect.width() - viewportSize. width())); 109 windowRect.setWidth(features.width + (windowRect.width() - viewportSize. width()));
110 if (features.heightSet) 110 if (features.heightSet)
111 windowRect.setHeight(features.height + (windowRect.height() - viewportSi ze.height())); 111 windowRect.setHeight(features.height + (windowRect.height() - viewportSi ze.height()));
112 112
113 host->chromeClient().setWindowRect(windowRect); 113 host->chromeClient().setWindowRectWithAdjustment(windowRect);
114 host->chromeClient().show(policy); 114 host->chromeClient().show(policy);
115 115
116 // TODO(japhet): There's currently no way to set sandbox flags on a RemoteFr ame and have it propagate 116 // TODO(japhet): There's currently no way to set sandbox flags on a RemoteFr ame and have it propagate
117 // to the real frame in a different process. See crbug.com/483584. 117 // to the real frame in a different process. See crbug.com/483584.
118 if (frame.isLocalFrame() && openerFrame.document()->isSandboxed(SandboxPropa gatesToAuxiliaryBrowsingContexts)) 118 if (frame.isLocalFrame() && openerFrame.document()->isSandboxed(SandboxPropa gatesToAuxiliaryBrowsingContexts))
119 toLocalFrame(&frame)->loader().forceSandboxFlags(openerFrame.document()- >sandboxFlags()); 119 toLocalFrame(&frame)->loader().forceSandboxFlags(openerFrame.document()- >sandboxFlags());
120 120
121 return &frame; 121 return &frame;
122 } 122 }
123 123
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 } 190 }
191 191
192 // TODO(japhet): Form submissions on RemoteFrames don't work yet. 192 // TODO(japhet): Form submissions on RemoteFrames don't work yet.
193 FrameLoadRequest newRequest(0, request.resourceRequest()); 193 FrameLoadRequest newRequest(0, request.resourceRequest());
194 newRequest.setForm(request.form()); 194 newRequest.setForm(request.form());
195 if (newFrame->isLocalFrame()) 195 if (newFrame->isLocalFrame())
196 toLocalFrame(newFrame)->loader().load(newRequest); 196 toLocalFrame(newFrame)->loader().load(newRequest);
197 } 197 }
198 198
199 } // namespace blink 199 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/page/ChromeClient.cpp ('k') | Source/web/ChromeClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698