Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: Source/core/page/ChromeClient.h

Issue 1167653007: Cleanup: Rename ChromeClient::setWindowRect and setWindowRectInternal. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/loader/EmptyClients.h ('k') | Source/core/page/ChromeClient.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/ChromeClient.h
diff --git a/Source/core/page/ChromeClient.h b/Source/core/page/ChromeClient.h
index 14e72b9e4255e12873797fd2454b4d2b1db47125..46db14d483d61594e423c730837ffa072185bd9e 100644
--- a/Source/core/page/ChromeClient.h
+++ b/Source/core/page/ChromeClient.h
@@ -76,7 +76,9 @@ class CORE_EXPORT ChromeClient : public HostWindow {
public:
virtual void chromeDestroyed() = 0;
- void setWindowRect(const IntRect&);
+ // The specified rectangle is adjusted for the minimum window size and the
+ // screen, then setWindowRect with the adjusted rectangle is called.
+ void setWindowRectWithAdjustment(const IntRect&);
virtual IntRect windowRect() = 0;
virtual IntRect pageRect() = 0;
@@ -245,10 +247,10 @@ protected:
virtual ~ChromeClient() { }
virtual void showMouseOverURL(const HitTestResult&) = 0;
+ virtual void setWindowRect(const IntRect&) = 0;
// TODO(tkent): Adding 'Internal' to virtual functions is not good. We
// should give better names, or move out non-internal versions of these
// functions.
- virtual void setWindowRectInternal(const IntRect&) = 0;
virtual bool runBeforeUnloadConfirmPanelInternal(LocalFrame*, const String& message) = 0;
virtual void runJavaScriptAlertInternal(LocalFrame*, const String&) = 0;
virtual bool runJavaScriptConfirmInternal(LocalFrame*, const String&) = 0;
« no previous file with comments | « Source/core/loader/EmptyClients.h ('k') | Source/core/page/ChromeClient.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698