Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Side by Side Diff: Source/core/page/ChromeClient.h

Issue 1167653007: Cleanup: Rename ChromeClient::setWindowRect and setWindowRectInternal. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/loader/EmptyClients.h ('k') | Source/core/page/ChromeClient.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple, Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple, Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 4 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 struct DateTimeChooserParameters; 69 struct DateTimeChooserParameters;
70 struct FrameLoadRequest; 70 struct FrameLoadRequest;
71 struct GraphicsDeviceAdapter; 71 struct GraphicsDeviceAdapter;
72 struct ViewportDescription; 72 struct ViewportDescription;
73 struct WindowFeatures; 73 struct WindowFeatures;
74 74
75 class CORE_EXPORT ChromeClient : public HostWindow { 75 class CORE_EXPORT ChromeClient : public HostWindow {
76 public: 76 public:
77 virtual void chromeDestroyed() = 0; 77 virtual void chromeDestroyed() = 0;
78 78
79 void setWindowRect(const IntRect&); 79 // The specified rectangle is adjusted for the minimum window size and the
80 // screen, then setWindowRect with the adjusted rectangle is called.
81 void setWindowRectWithAdjustment(const IntRect&);
80 virtual IntRect windowRect() = 0; 82 virtual IntRect windowRect() = 0;
81 83
82 virtual IntRect pageRect() = 0; 84 virtual IntRect pageRect() = 0;
83 85
84 virtual void focus() = 0; 86 virtual void focus() = 0;
85 87
86 virtual bool canTakeFocus(WebFocusType) = 0; 88 virtual bool canTakeFocus(WebFocusType) = 0;
87 virtual void takeFocus(WebFocusType) = 0; 89 virtual void takeFocus(WebFocusType) = 0;
88 90
89 virtual void focusedNodeChanged(Node*, Node*) = 0; 91 virtual void focusedNodeChanged(Node*, Node*) = 0;
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 virtual void didUpdateTopControls() const { } 240 virtual void didUpdateTopControls() const { }
239 241
240 void registerPopupOpeningObserver(PopupOpeningObserver*); 242 void registerPopupOpeningObserver(PopupOpeningObserver*);
241 void unregisterPopupOpeningObserver(PopupOpeningObserver*); 243 void unregisterPopupOpeningObserver(PopupOpeningObserver*);
242 void notifyPopupOpeningObservers() const; 244 void notifyPopupOpeningObservers() const;
243 245
244 protected: 246 protected:
245 virtual ~ChromeClient() { } 247 virtual ~ChromeClient() { }
246 248
247 virtual void showMouseOverURL(const HitTestResult&) = 0; 249 virtual void showMouseOverURL(const HitTestResult&) = 0;
250 virtual void setWindowRect(const IntRect&) = 0;
248 // TODO(tkent): Adding 'Internal' to virtual functions is not good. We 251 // TODO(tkent): Adding 'Internal' to virtual functions is not good. We
249 // should give better names, or move out non-internal versions of these 252 // should give better names, or move out non-internal versions of these
250 // functions. 253 // functions.
251 virtual void setWindowRectInternal(const IntRect&) = 0;
252 virtual bool runBeforeUnloadConfirmPanelInternal(LocalFrame*, const String& message) = 0; 254 virtual bool runBeforeUnloadConfirmPanelInternal(LocalFrame*, const String& message) = 0;
253 virtual void runJavaScriptAlertInternal(LocalFrame*, const String&) = 0; 255 virtual void runJavaScriptAlertInternal(LocalFrame*, const String&) = 0;
254 virtual bool runJavaScriptConfirmInternal(LocalFrame*, const String&) = 0; 256 virtual bool runJavaScriptConfirmInternal(LocalFrame*, const String&) = 0;
255 virtual bool runJavaScriptPromptInternal(LocalFrame*, const String& message, const String& defaultValue, String& result) = 0; 257 virtual bool runJavaScriptPromptInternal(LocalFrame*, const String& message, const String& defaultValue, String& result) = 0;
256 virtual void printInternal(LocalFrame*) = 0; 258 virtual void printInternal(LocalFrame*) = 0;
257 virtual PassOwnPtrWillBeRawPtr<ColorChooser> createColorChooserInternal(Loca lFrame*, ColorChooserClient*, const Color&) = 0; 259 virtual PassOwnPtrWillBeRawPtr<ColorChooser> createColorChooserInternal(Loca lFrame*, ColorChooserClient*, const Color&) = 0;
258 virtual PassRefPtr<DateTimeChooser> openDateTimeChooserInternal(DateTimeChoo serClient*, const DateTimeChooserParameters&) = 0; 260 virtual PassRefPtr<DateTimeChooser> openDateTimeChooserInternal(DateTimeChoo serClient*, const DateTimeChooserParameters&) = 0;
259 virtual void openTextDataListChooserInternal(HTMLInputElement&) = 0; 261 virtual void openTextDataListChooserInternal(HTMLInputElement&) = 0;
260 virtual void runOpenPanelInternal(LocalFrame*, PassRefPtr<FileChooser>) = 0; 262 virtual void runOpenPanelInternal(LocalFrame*, PassRefPtr<FileChooser>) = 0;
261 virtual PassRefPtrWillBeRawPtr<PopupMenu> createPopupMenuInternal(LocalFrame &, PopupMenuClient*) = 0; 263 virtual PassRefPtrWillBeRawPtr<PopupMenu> createPopupMenuInternal(LocalFrame &, PopupMenuClient*) = 0;
262 virtual void setCursorInternal(const Cursor&) = 0; 264 virtual void setCursorInternal(const Cursor&) = 0;
263 265
264 private: 266 private:
265 bool canRunModalIfDuringPageDismissal(Frame* mainFrame, DialogType, const St ring& message); 267 bool canRunModalIfDuringPageDismissal(Frame* mainFrame, DialogType, const St ring& message);
266 void setToolTip(const HitTestResult&); 268 void setToolTip(const HitTestResult&);
267 269
268 Vector<PopupOpeningObserver*> m_popupOpeningObservers; 270 Vector<PopupOpeningObserver*> m_popupOpeningObservers;
269 Cursor m_lastSetMouseCursorForTesting; 271 Cursor m_lastSetMouseCursorForTesting;
270 }; 272 };
271 273
272 } // namespace blink 274 } // namespace blink
273 275
274 #endif // ChromeClient_h 276 #endif // ChromeClient_h
OLDNEW
« no previous file with comments | « Source/core/loader/EmptyClients.h ('k') | Source/core/page/ChromeClient.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698