Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1167623004: Don't persist immediate content setting decisions in GeolocationPermissionContext::RequestPermissio… (Closed)

Created:
5 years, 6 months ago by Bernhard Bauer
Modified:
5 years, 6 months ago
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, mlamouri+watch-geolocation_chromium.org, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't persist immediate content setting decisions in GeolocationPermissionContext::RequestPermission(). Immediatey content setting decisions are not the result of a user decision, so they should not be stored in the content settings map. BUG=495178 Committed: https://crrev.com/86abdf07bc132436bcbce5ab72118070024ede38 Cr-Commit-Position: refs/heads/master@{#332829}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/geolocation/geolocation_permission_context.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Bernhard Bauer
Please review.
5 years, 6 months ago (2015-06-03 11:16:38 UTC) #2
Michael van Ouwerkerk
lgtm https://codereview.chromium.org/1167623004/diff/1/chrome/browser/geolocation/geolocation_permission_context.cc File chrome/browser/geolocation/geolocation_permission_context.cc (right): https://codereview.chromium.org/1167623004/diff/1/chrome/browser/geolocation/geolocation_permission_context.cc#newcode45 chrome/browser/geolocation/geolocation_permission_context.cc:45: false, nit: add /* persist */ for readability.
5 years, 6 months ago (2015-06-04 12:50:39 UTC) #3
Bernhard Bauer
https://codereview.chromium.org/1167623004/diff/1/chrome/browser/geolocation/geolocation_permission_context.cc File chrome/browser/geolocation/geolocation_permission_context.cc (right): https://codereview.chromium.org/1167623004/diff/1/chrome/browser/geolocation/geolocation_permission_context.cc#newcode45 chrome/browser/geolocation/geolocation_permission_context.cc:45: false, On 2015/06/04 12:50:38, Michael van Ouwerkerk wrote: > ...
5 years, 6 months ago (2015-06-04 13:22:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167623004/20001
5 years, 6 months ago (2015-06-04 13:22:58 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-04 14:02:53 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 14:03:37 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/86abdf07bc132436bcbce5ab72118070024ede38
Cr-Commit-Position: refs/heads/master@{#332829}

Powered by Google App Engine
This is Rietveld 408576698