Don't persist immediate content setting decisions in GeolocationPermissionContext::RequestPermissio…

chrome/browser/geolocation/geolocation_permission_context.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/geolocation/geolocation_permission_context.h"
 
 #include "base/bind.h"
 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
 #include "chrome/browser/profiles/profile.h"
 #include "components/content_settings/core/common/permission_request_id.h"
@@ skipping 24 matching lines @@
   if (extensions_context_.RequestPermission(
       web_contents, id, id.bridge_id(), requesting_frame_origin, user_gesture,
       callback, &permission_set, &new_permission)) {
     if (permission_set) {
       ContentSetting content_setting =
           new_permission ? CONTENT_SETTING_ALLOW : CONTENT_SETTING_BLOCK;
       NotifyPermissionSet(id,
                           requesting_frame_origin,
                           web_contents->GetLastCommittedURL().GetOrigin(),
                           callback,
-                          true,
+                          false,

[Michael van Ouwerkerk, 2015/06/04 12:50:38]

nit: add /* persist */ for readability.

[Bernhard Bauer, 2015/06/04 13:22:36]

Done.

                           content_setting);
     }
     return;
   }
 
   PermissionContextBase::RequestPermission(web_contents, id,
                                            requesting_frame_origin,
                                            user_gesture,
                                            callback);
 }
@@ skipping 22 matching lines @@
 
   if (allowed) {
     content::GeolocationProvider::GetInstance()
         ->UserDidOptIntoLocationServices();
   }
 }
 
 bool GeolocationPermissionContext::IsRestrictedToSecureOrigins() const {
   return false;
 }