Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1317)

Issue 1167623002: Sync some event interfaces with the HTML spec (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
bashi
CC:
blink-reviews, shans, arv+blink, vivekg_samsung, blink-reviews-animation_chromium.org, vivekg, Inactive, darktears, rjwright, Eric Willigers
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync some event interfaces with the HTML spec There are no changes to the generated code other than order and the use counter. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196213

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -21 lines) Patch
M Source/core/events/AutocompleteErrorEvent.idl View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/events/BeforeUnloadEvent.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/events/ErrorEvent.idl View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/events/HashChangeEvent.idl View 1 chunk +11 lines, -7 lines 0 comments Download
M Source/core/events/MessageEvent.idl View 2 chunks +7 lines, -3 lines 0 comments Download
M Source/core/events/PageTransitionEvent.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/events/PageTransitionEventInit.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/PopStateEvent.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/events/PopStateEventInit.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/RelatedEvent.idl View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/events/RelatedEventInit.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
philipj_slow
PTAL
5 years, 6 months ago (2015-05-31 21:02:56 UTC) #2
bashi
LGTM
5 years, 6 months ago (2015-06-01 01:27:22 UTC) #3
philipj_slow
rebase
5 years, 6 months ago (2015-06-01 08:04:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167623002/20001
5 years, 6 months ago (2015-06-01 08:05:01 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 09:21:13 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196213

Powered by Google App Engine
This is Rietveld 408576698