Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Unified Diff: Source/core/events/MessageEvent.idl

Issue 1167623002: Sync some event interfaces with the HTML spec (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/events/HashChangeEvent.idl ('k') | Source/core/events/PageTransitionEvent.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/events/MessageEvent.idl
diff --git a/Source/core/events/MessageEvent.idl b/Source/core/events/MessageEvent.idl
index 2dea4ed9fd661aeff1c08bc2cf5f85b3d7d115ac..588a9397f371543fcd79ae406553a67b5ae516e7 100644
--- a/Source/core/events/MessageEvent.idl
+++ b/Source/core/events/MessageEvent.idl
@@ -32,11 +32,15 @@
Exposed=(Window,Worker),
RaisesException=Constructor,
] interface MessageEvent : Event {
+ [Custom=Getter] readonly attribute any data;
readonly attribute DOMString origin;
readonly attribute DOMString lastEventId;
- readonly attribute EventTarget? source; // May be a Window or a MessagePort
- [Custom=Getter] readonly attribute any data;
+ // TODO(bashi): |source| should be (WindowProxy or MessagePort)?
+ readonly attribute EventTarget? source;
readonly attribute MessagePort[]? ports;
+
+ // TODO(philipj): None of the initMessageEvent() arguments should be
+ // optional, and |sourceArg| and |portsArg| are of the wrong type.
[Custom, MeasureAs=InitMessageEvent] void initMessageEvent([Default=Undefined] optional DOMString typeArg,
[Default=Undefined] optional boolean canBubbleArg,
[Default=Undefined] optional boolean cancelableArg,
@@ -44,5 +48,5 @@
[Default=Undefined] optional DOMString originArg,
[Default=Undefined] optional DOMString lastEventIdArg,
[Default=Undefined] optional Window sourceArg,
- [Default=Undefined] optional MessagePort[] messagePorts);
+ [Default=Undefined] optional MessagePort[] portsArg);
};
« no previous file with comments | « Source/core/events/HashChangeEvent.idl ('k') | Source/core/events/PageTransitionEvent.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698