Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: Source/BUILD.gn

Issue 1167523003: Define a variable to distinguish system_icu from bundled_icu in Blink (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix the comment in BUILD.gn Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/encoding/char-encoding-expected.txt ('k') | Source/config.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/BUILD.gn
diff --git a/Source/BUILD.gn b/Source/BUILD.gn
index 30cafc159837538d94d19537592febdc3c78db87..4db0db7b4f7a5c11c834bac2a047890dc8be87ad 100644
--- a/Source/BUILD.gn
+++ b/Source/BUILD.gn
@@ -67,6 +67,11 @@ config("config") {
#'cflags': ['<!@(../../../tools/clang/scripts/blink_gc_plugin_flags.py enable-oilpan=<(enable_oilpan) dump-graph=<(blink_gc_plugin_dump_graph))'],
}
}
+
+ ## TODO(GYP) : gn does not yet support use_system_icu.
+ #if (use_system_icu) {
+ # defines += [ "USING_SYSTEM_ICU" ]
+ #}
}
# The follow configs apply to all targets except for unit tests, which rely on
« no previous file with comments | « LayoutTests/fast/encoding/char-encoding-expected.txt ('k') | Source/config.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698