Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Side by Side Diff: Source/BUILD.gn

Issue 1167523003: Define a variable to distinguish system_icu from bundled_icu in Blink (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix the comment in BUILD.gn Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/fast/encoding/char-encoding-expected.txt ('k') | Source/config.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("config.gni") 5 import("config.gni")
6 if (is_clang) { 6 if (is_clang) {
7 import("//build/config/clang/clang.gni") 7 import("//build/config/clang/clang.gni")
8 } 8 }
9 9
10 visibility = [ "//third_party/WebKit/*" ] 10 visibility = [ "//third_party/WebKit/*" ]
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 # timesNewRoman.unstatic.3258 and colorTransparent.unstatic.4879. 60 # timesNewRoman.unstatic.3258 and colorTransparent.unstatic.4879.
61 cflags += [ "-Wno-uninitialized" ] 61 cflags += [ "-Wno-uninitialized" ]
62 } 62 }
63 63
64 if (is_clang) { 64 if (is_clang) {
65 if (blink_gc_plugin && clang_use_chrome_plugins) { 65 if (blink_gc_plugin && clang_use_chrome_plugins) {
66 # TODO(GYP) 66 # TODO(GYP)
67 #'cflags': ['<!@(../../../tools/clang/scripts/blink_gc_plugin_flags.py ena ble-oilpan=<(enable_oilpan) dump-graph=<(blink_gc_plugin_dump_graph))'], 67 #'cflags': ['<!@(../../../tools/clang/scripts/blink_gc_plugin_flags.py ena ble-oilpan=<(enable_oilpan) dump-graph=<(blink_gc_plugin_dump_graph))'],
68 } 68 }
69 } 69 }
70
71 ## TODO(GYP) : gn does not yet support use_system_icu.
72 #if (use_system_icu) {
73 # defines += [ "USING_SYSTEM_ICU" ]
74 #}
70 } 75 }
71 76
72 # The follow configs apply to all targets except for unit tests, which rely on 77 # The follow configs apply to all targets except for unit tests, which rely on
73 # static initializers. 78 # static initializers.
74 config("non_test_config") { 79 config("non_test_config") {
75 cflags = [] 80 cflags = []
76 81
77 if (is_clang) { 82 if (is_clang) {
78 cflags += [ "-Wglobal-constructors" ] 83 cflags += [ "-Wglobal-constructors" ]
79 } 84 }
80 } 85 }
OLDNEW
« no previous file with comments | « LayoutTests/fast/encoding/char-encoding-expected.txt ('k') | Source/config.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698