Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: extensions/renderer/resource_bundle_source_map.cc

Issue 1167423002: Use V8 Maybe APIs in extensions/renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/render_view_observer_natives.cc ('k') | extensions/renderer/runtime_custom_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/resource_bundle_source_map.cc
diff --git a/extensions/renderer/resource_bundle_source_map.cc b/extensions/renderer/resource_bundle_source_map.cc
index 88fc5372185d0ebd511fc7c8cd716914701480e3..09f2a98d830993fc580492111370647cb57a345d 100644
--- a/extensions/renderer/resource_bundle_source_map.cc
+++ b/extensions/renderer/resource_bundle_source_map.cc
@@ -48,8 +48,9 @@ v8::Local<v8::String> ResourceBundleSourceMap::ConvertString(
const base::StringPiece& string) {
// v8 takes ownership of the StaticV8ExternalOneByteStringResource (see
// v8::String::NewExternal()).
- return v8::String::NewExternal(
- isolate, new StaticV8ExternalOneByteStringResource(string));
+ return v8::String::NewExternalOneByte(
+ isolate, new StaticV8ExternalOneByteStringResource(string))
+ .ToLocalChecked();
}
} // namespace extensions
« no previous file with comments | « extensions/renderer/render_view_observer_natives.cc ('k') | extensions/renderer/runtime_custom_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698