Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1167343003: Revert of [test] Refactoring - Let runner handle test IDs. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [test] Refactoring - Let runner handle test IDs. (patchset #1 id:1 of https://codereview.chromium.org/1168303007/) Reason for revert: [Sheriff] Revert until the tree is in a better state. Original issue's description: > [test] Refactoring - Let runner handle test IDs. > > This prepares for properly rerunning tests. Currently when > tests are rerun, the same test object is reused. This > will be changed in a follow up. > > Committed: https://crrev.com/f41a81b8a513fc360c500c066b74f223bc9c0223 > Cr-Commit-Position: refs/heads/master@{#28864} TBR=jkummerow@chromium.org,tandrii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/f83444a5f24381ec9ccc28b1e18e1e9370415bb2 Cr-Commit-Position: refs/heads/master@{#28891}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M tools/run-tests.py View 2 chunks +4 lines, -0 lines 0 comments Download
M tools/testrunner/local/execution.py View 2 chunks +5 lines, -10 lines 0 comments Download
M tools/testrunner/network/network_execution.py View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
Created Revert of [test] Refactoring - Let runner handle test IDs.
5 years, 6 months ago (2015-06-10 06:46:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167343003/1
5 years, 6 months ago (2015-06-10 06:46:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 06:46:39 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f83444a5f24381ec9ccc28b1e18e1e9370415bb2 Cr-Commit-Position: refs/heads/master@{#28891}
5 years, 6 months ago (2015-06-10 06:46:55 UTC) #4
Michael Achenbach
5 years, 6 months ago (2015-06-10 10:14:32 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1179483002/ by machenbach@chromium.org.

The reason for reverting is: All build problems had other reasons..

Powered by Google App Engine
This is Rietveld 408576698