Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 1167223002: Make v8 snapshot public in component build. (Closed)

Created:
5 years, 6 months ago by brettw
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make v8 snapshot public in component build. This was already public in a non-component build. This means that targets dependent on the "v8" target can take the results of the snapshot as inputs. This also renames the component mode checking from keying off of the component_mode string to checking the is_component_build flag, which is now the recommended way to do this check. Committed: https://crrev.com/4cf578a1ea7e9d69412de8b957d6b8cd3329730e Cr-Commit-Position: refs/heads/master@{#28856}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M BUILD.gn View 4 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
brettw
If possible, can you land this for me?
5 years, 6 months ago (2015-06-08 20:17:49 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-09 08:03:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167223002/20001
5 years, 6 months ago (2015-06-09 08:03:40 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-09 08:36:15 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 08:36:23 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4cf578a1ea7e9d69412de8b957d6b8cd3329730e
Cr-Commit-Position: refs/heads/master@{#28856}

Powered by Google App Engine
This is Rietveld 408576698