Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: BUILD.gn

Issue 1167223002: Make v8 snapshot public in component build. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index cffd8f07557bc37835304d8d1564adbc4e0c4111..2f108d0803ef0e3995288f9ba1d2d3ecfa8a01bb 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -52,7 +52,7 @@ config("internal_config") {
include_dirs = [ "." ]
- if (component_mode == "shared_library") {
+ if (is_component_build) {
defines = [
"V8_SHARED",
"BUILDING_V8_SHARED",
@@ -1567,7 +1567,7 @@ if (current_toolchain == snapshot_toolchain) {
# Public targets
#
-if (component_mode == "shared_library") {
+if (is_component_build) {
component("v8") {
sources = [
"src/v8dll-main.cc",
@@ -1576,6 +1576,8 @@ if (component_mode == "shared_library") {
if (v8_use_snapshot && v8_use_external_startup_data) {
deps = [
":v8_base",
+ ]
+ public_deps = [
":v8_external_snapshot",
]
} else if (v8_use_snapshot) {
@@ -1672,7 +1674,7 @@ if ((current_toolchain == host_toolchain && v8_toolset_for_d8 == "host") ||
sources += [ "src/d8-windows.cc" ]
}
- if (component_mode != "shared_library") {
+ if (!is_component_build) {
sources += [
"src/d8-debug.cc",
"$target_gen_dir/d8-js.cc",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698