[Android] Remove adb_commands from telemetry. (Reland)

[Android] Remove adb_commands from telemetry. (Reland)

This is a reland of https://codereview.chromium.org/1141833003, which
was originally reverted for breaking telemetry on non-rooted devices.

BUG=476709

[jbudorick, 2015-06-08 18:51:14]

jbudorick@chromium.org changed reviewers:
+ nednguyen@google.com, sullivan@chromium.org

[jbudorick, 2015-06-08 18:51:15]

fwiw, I don't plan to land this until we've stabilized the Android bots, but I'm
hoping that https://codereview.chromium.org/1152293008 will do that.

[nednguyen, 2015-06-08 18:53:17]

nednguyen@google.com changed reviewers:
+ dtu@chromium.org

[nednguyen, 2015-06-08 21:03:03]

On 2015/06/08 18:53:18, nednguyen wrote:

Should we break this giant patch to smaller ones to reduce the risk of
functional change?

[jbudorick, 2015-06-08 21:55:50]

On 2015/06/08 at 21:03:03, nednguyen wrote:
> On 2015/06/08 18:53:18, nednguyen wrote:
> 
> Should we break this giant patch to smaller ones to reduce the risk of
functional change?

Personally, I'd prefer not doing that in this case because adb_commands is a ...
mess ... and doing a phased transition is liable to confuse people. (It
certainly has with AndroidCommands -> DeviceUtils, but that has been a much,
much bigger change.)

I guess I could:
 - add device to android_browser_backend
 - switch all of its clients over
 - switch other direct uses of adb_commands
 - and then remove adb_commands...?

if you'd prefer.

[nednguyen, 2015-06-08 21:59:53]

On 2015/06/08 21:55:50, jbudorick wrote:
> On 2015/06/08 at 21:03:03, nednguyen wrote:
> > On 2015/06/08 18:53:18, nednguyen wrote:
> > 
> > Should we break this giant patch to smaller ones to reduce the risk of
> functional change?
> 
> Personally, I'd prefer not doing that in this case because adb_commands is a
...
> mess ... and doing a phased transition is liable to confuse people. (It
> certainly has with AndroidCommands -> DeviceUtils, but that has been a much,
> much bigger change.)
> 
> I guess I could:
>  - add device to android_browser_backend
>  - switch all of its clients over
>  - switch other direct uses of adb_commands
>  - and then remove adb_commands...?
> 
> if you'd prefer.

This plan SGTM.

[jbudorick, 2015-06-08 22:08:26]

On 2015/06/08 at 21:59:53, nednguyen wrote:
> On 2015/06/08 21:55:50, jbudorick wrote:
> > On 2015/06/08 at 21:03:03, nednguyen wrote:
> > > On 2015/06/08 18:53:18, nednguyen wrote:
> > > 
> > > Should we break this giant patch to smaller ones to reduce the risk of
> > functional change?
> > 
> > Personally, I'd prefer not doing that in this case because adb_commands is a
...
> > mess ... and doing a phased transition is liable to confuse people. (It
> > certainly has with AndroidCommands -> DeviceUtils, but that has been a much,
> > much bigger change.)
> > 
> > I guess I could:
> >  - add device to android_browser_backend
> >  - switch all of its clients over
> >  - switch other direct uses of adb_commands
> >  - and then remove adb_commands...?
> > 
> > if you'd prefer.
> 
> This plan SGTM.

:/ ok

closing this review, will upload first review in that chain later in the week.

[nednguyen, 2015-07-10 14:58:23]

lgtm

[alexclarke, 2015-07-13 10:33:43]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1233643004/ by alexclarke@google.com.

The reason for reverting is: This patch broke the android perf bots.

http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus4%20Perf/bu...
http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf/bu...
http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf/...
http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf/bu...
http://build.chromium.org/p/chromium.perf/builders/Android%20One%20Perf/build....

[chromium-reviews, 2015-07-13 11:33:48]

Never mind.  This wasn't it.

On Mon, Jul 13, 2015 at 11:33 AM, <alexclarke@google.com> wrote:

> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1233643004/ by alexclarke@google.com.
>
> The reason for reverting is: This patch broke the android perf bots.
>
>
>
http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus4%20Perf/bu...
>
>
http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf/bu...
>
>
http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf/...
>
>
http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf/bu...
>
>
http://build.chromium.org/p/chromium.perf/builders/Android%20One%20Perf/build...
> .
>
> https://codereview.chromium.org/1167173002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.