Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1152293008: [Android] Speculative fix: use WaitUntilFullyBooted in telemetry. (Closed)

Created:
5 years, 6 months ago by jbudorick
Modified:
5 years, 6 months ago
Reviewers:
sullivan, nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Speculative fix: use WaitUntilFullyBooted in telemetry. adb wait-for-device (and thus AdbWrapper.WaitForDevice) can return before the device is completely ready for use (see e.g. crbug/493900). Switching to DeviceUtils.WaitUntilFullyBooted ensures that the device is either ready or is irrecoverably gone. BUG=489317 Committed: https://crrev.com/249ef482e6d380132994991f197f66832dc8e4f5 Cr-Commit-Position: refs/heads/master@{#333290}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/telemetry/telemetry/core/forwarders/android_forwarder.py View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbudorick
5 years, 6 months ago (2015-06-08 16:49:49 UTC) #2
nednguyen
lgtm
5 years, 6 months ago (2015-06-08 16:50:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152293008/1
5 years, 6 months ago (2015-06-08 16:52:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-08 17:58:57 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 18:00:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/249ef482e6d380132994991f197f66832dc8e4f5
Cr-Commit-Position: refs/heads/master@{#333290}

Powered by Google App Engine
This is Rietveld 408576698