chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc - Issue 1167163002: chrome: Remove use of MessageLoopProxy and deprecated MessageLoop APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

Issue 1167163002: chrome: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added some missing message_loop.h includes. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc ('k') | chrome/renderer/safe_browsing/phishing_term_feature_extractor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

diff --git a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

index 83746a01759016931356a18b6673bacac4939491..c15219fcffa942f488a374037268bd1f46b5863f 100644

--- a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

+++ b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

@@ -13,9 +13,11 @@

#include "base/callback.h"

#include "base/command_line.h"

#include "base/compiler_specific.h"

+#include "base/location.h"

#include "base/memory/weak_ptr.h"

-#include "base/message_loop/message_loop.h"

+#include "base/single_thread_task_runner.h"

#include "base/strings/string_number_conversions.h"

+#include "base/thread_task_runner_handle.h"

#include "base/time/time.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

@@ -62,10 +64,9 @@ class PhishingDOMFeatureExtractorTest : public InProcessBrowserTest {

// Helper for the SubframeRemoval test that posts a message to remove

// the iframe "frame1" from the document.

void ScheduleRemoveIframe() {

- base::MessageLoop::current()->PostTask(

- FROM_HERE,

- base::Bind(&PhishingDOMFeatureExtractorTest::RemoveIframe,

- weak_factory_.GetWeakPtr()));

+ base::ThreadTaskRunnerHandle::Get()->PostTask(

+ FROM_HERE, base::Bind(&PhishingDOMFeatureExtractorTest::RemoveIframe,

+ weak_factory_.GetWeakPtr()));

}

protected: