chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc - Issue 1167163002: chrome: Remove use of MessageLoopProxy and deprecated MessageLoop APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc

Issue 1167163002: chrome: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added some missing message_loop.h includes. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc ('k') | chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc

diff --git a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc

index 9c92c9a1840196c8881dcd1a97275de8bb445c57..f47a186a098cf937f290461cd67fb7db55c6580a 100644

--- a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc

+++ b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc

@@ -7,10 +7,12 @@

#include "base/bind.h"

#include "base/compiler_specific.h"

#include "base/containers/hash_tables.h"

+#include "base/location.h"

#include "base/logging.h"

-#include "base/message_loop/message_loop.h"

#include "base/metrics/histogram.h"

+#include "base/single_thread_task_runner.h"

#include "base/strings/string_util.h"

+#include "base/thread_task_runner_handle.h"

#include "base/time/time.h"

#include "chrome/renderer/safe_browsing/feature_extractor_clock.h"

#include "chrome/renderer/safe_browsing/features.h"

@@ -133,7 +135,7 @@ void PhishingDOMFeatureExtractor::ExtractFeatures(

cur_document_ = web_view->mainFrame()->document();

}

- base::MessageLoop::current()->PostTask(

+ base::ThreadTaskRunnerHandle::Get()->PostTask(

FROM_HERE,

base::Bind(&PhishingDOMFeatureExtractor::ExtractFeaturesWithTimeout,

weak_factory_.GetWeakPtr()));

@@ -213,7 +215,7 @@ void PhishingDOMFeatureExtractor::ExtractFeaturesWithTimeout() {

// clock granularity.

UMA_HISTOGRAM_TIMES("SBClientPhishing.DOMFeatureChunkTime",

chunk_elapsed);

- base::MessageLoop::current()->PostTask(

+ base::ThreadTaskRunnerHandle::Get()->PostTask(

FROM_HERE,

base::Bind(

&PhishingDOMFeatureExtractor::ExtractFeaturesWithTimeout,