Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1167113002: [NaCl SDK] Add include of stdint.h to netdb.h (Closed)

Created:
5 years, 6 months ago by Sam Clegg
Modified:
5 years, 6 months ago
Reviewers:
binji
CC:
binji+watch_chromium.org, chromium-reviews, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Add include of stdint.h to netdb.h uint32_t is used in the declaration of getnetbyaddr but stdin.h was not directly included. This will be needed once this change the newlib headers lands: https://codereview.chromium.org/1163893003 BUG= https://code.google.com/p/nativeclient/issues/detail?id=4198 Committed: https://crrev.com/8ee7ead35e43c801531285603c1f4383249c6f37 Cr-Commit-Position: refs/heads/master@{#333601}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M native_client_sdk/src/libraries/third_party/newlib-extras/netdb.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Sam Clegg
5 years, 6 months ago (2015-06-08 17:43:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167113002/20001
5 years, 6 months ago (2015-06-08 17:45:43 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-08 18:19:34 UTC) #6
binji
lgtm
5 years, 6 months ago (2015-06-09 21:13:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167113002/20001
5 years, 6 months ago (2015-06-09 21:42:41 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-09 22:50:18 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 22:51:58 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ee7ead35e43c801531285603c1f4383249c6f37
Cr-Commit-Position: refs/heads/master@{#333601}

Powered by Google App Engine
This is Rietveld 408576698