Don't include <stdint.h> from within <machine/_types.h>

Don't include <stdint.h> from within <machine/_types.h>

This causes no end of problem for with gnulib that
likes to create wrappers around standard library
headers.

Probably best that a low level header like machine/_types.h
doesn't depend on a higher level standard header like
stdint.h

CQ_EXTRA_TRYBOTS=tryserver.nacl:nacl-toolchain-precise64-newlib
BUG= https://code.google.com/p/nativeclient/issues/detail?id=4198

Committed: https://chromium.googlesource.com/native_client/src/native_client/+/a1e908751e321b70b7921c667e9ab1ddfa642303

[Sam Clegg, 2015-07-17 20:10:27]

sbc@chromium.org changed reviewers:
+ mcgrathr@chromium.org

[Roland McGrath, 2015-07-17 20:28:00]

LGTM but it needs successful try runs on toolchain bots to ensure that the
effects on these header files when massaged into the newlib toolchain don't
break anything.

[Sam Clegg, 2015-07-20 00:30:37]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2015-07-20 00:30:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163893003/120001

[commit-bot: I haz the power, 2015-07-20 00:33:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-20 00:33:09]

Try jobs failed on following builders:
  nacl-presubmit on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-presubmit/builds/220)

[Sam Clegg, 2015-07-20 04:33:51]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2015-07-20 04:33:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
mcgrathr@chromium.org
Link to the patchset: https://codereview.chromium.org/1163893003/#ps140001
(title: " ")

[commit-bot: I haz the power, 2015-07-20 04:33:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163893003/140001

[commit-bot: I haz the power, 2015-07-20 04:35:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-20 04:35:50]

Try jobs failed on following builders:
  nacl-presubmit on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-presubmit/builds/222)

[Sam Clegg, 2015-07-20 15:11:30]

sbc@chromium.org changed reviewers:
+ bradnelson@chromium.org

[Sam Clegg, 2015-07-20 15:11:31]

+bradnelson for service_runtime

[Sam Clegg, 2015-07-21 17:20:15]

+josephpereira (since this should fix your gnulib issues in naclports).

[bradn, 2015-07-21 17:21:44]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2015-07-21 17:21:44]

lgtm

[Sam Clegg, 2015-07-21 17:22:39]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2015-07-21 17:22:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163893003/140001

[commit-bot: I haz the power, 2015-07-21 17:25:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-21 17:25:39]

Try jobs failed on following builders:
  nacl-presubmit on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-presubmit/builds/225)

[Sam Clegg, 2015-07-21 17:28:22]

On 2015/07/21 17:21:44, bradn wrote:
> lgtm

Wrong account I think.

[bradnelson, 2015-07-21 17:31:14]

lgtm

[Sam Clegg, 2015-07-21 18:21:59]

Update PRESUBMIT.py.. so I can use the CQ for the this change.  PTAL.

[Sam Clegg, 2015-07-21 18:22:10]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2015-07-21 18:22:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
bradnelson@chromium.org, bradnelson@google.com, mcgrathr@chromium.org
Link to the patchset: https://codereview.chromium.org/1163893003/#ps160001
(title: " ")

[commit-bot: I haz the power, 2015-07-21 18:22:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163893003/160001

[commit-bot: I haz the power, 2015-07-22 00:56:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-22 00:56:27]

Try jobs failed on following builders:
  nacl-arm_opt_panda on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-arm_opt_panda/builds...)

[Sam Clegg, 2015-07-22 03:31:10]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2015-07-22 03:31:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163893003/160001

[commit-bot: I haz the power, 2015-07-22 17:22:11]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/native_client/src/native_client/+/a1e908751...

[Derek Schuff, 2015-07-23 15:51:56]

On 2015/07/22 17:22:11, commit-bot: I haz the power wrote:
> Committed patchset #9 (id:160001) as
>
https://chromium.googlesource.com/native_client/src/native_client/+/a1e908751...

+mseaborn
This seems to have broken the x86-32 nonsfi build on the toolchain waterfall:
http://build.chromium.org/p/client.nacl.toolchain/builders/linux-pnacl-x86_64...

But not the main waterfall, which seems odd. Sam and/or Mark, can you take a
look?

[Mark Seaborn, 2015-07-23 15:56:59]

On 23 July 2015 at 08:51, <dschuff@chromium.org> wrote:

> On 2015/07/22 17:22:11, commit-bot: I haz the power wrote:
>
>> Committed patchset #9 (id:160001) as
>>
>
>
>
https://chromium.googlesource.com/native_client/src/native_client/+/a1e908751...
>
> +mseaborn
> This seems to have broken the x86-32 nonsfi build on the toolchain
> waterfall:
>
>
http://build.chromium.org/p/client.nacl.toolchain/builders/linux-pnacl-x86_64...
>
> But not the main waterfall, which seems odd. Sam and/or Mark, can you take
> a
> look?


The error is:

native_client/src/nonsfi/linux/linux_pthread_private.h:26:28: error:
unknown type name 'int32_t'; did you mean '__int32_t'?
void nacl_user_thread_exit(int32_t *stack_flag);

So I think this just requires adding "#include <stdint.h>" that file.  Sam,
can you try that?

Mark

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.