Issue 1167023003: SkPDF/Device/ImageFilter: Fix ImageFilter fallback code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1167023003: SkPDF/Device/ImageFilter: Fix ImageFilter fallback code (Closed)

Created:
5 years, 6 months ago by hal.canary

Modified:
5 years, 6 months ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@m43

Target Ref:
refs/heads/chrome/m43

Project:
skia

Visibility:
Public.

SkPDF/Device/ImageFilter: Fix ImageFilter fallback code Broken in https://chromium.googlesource.com/skia/+/76033be I have confirmed that this fixes 470083. BUG=470083 Review URL: https://codereview.chromium.org/1080923004 [cherry-picked from commit 00b7e5e] NOTREECHECKS=true NOTRY=true R=reed@google.com Committed: https://skia.googlesource.com/skia/+/7be37a9beb17711b8f297fc47a4ae473d9b3c018

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -4 lines)			Patch
M	include/core/SkDevice.h	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/core/SkDeviceImageFilterProxy.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pdf/SkPDFDevice.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

hal.canary

5 years, 6 months ago (2015-06-05 20:00:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7be37a9beb17711b8f297fc47a4ae473d9b3c018 (presubmit successful).