Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1080923004: SkPDF/Device/ImageFilter: Fix ImageFilter fallback code (Closed)

Created:
5 years, 8 months ago by hal.canary
Modified:
5 years, 8 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF/Device/ImageFilter: Fix ImageFilter fallback code Broken in https://chromium.googlesource.com/skia/+/76033be I have confirmed that this fixes 470083. BUG=470083 Committed: https://skia.googlesource.com/skia/+/00b7e5eb973a1b1e4d1affa74fc0341e8c41e3da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M include/core/SkDevice.h View 1 chunk +6 lines, -2 lines 0 comments Download
M src/core/SkDeviceImageFilterProxy.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080923004/1
5 years, 8 months ago (2015-04-15 15:57:34 UTC) #2
hal.canary
PTAL
5 years, 8 months ago (2015-04-15 15:57:46 UTC) #4
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-15 16:03:32 UTC) #6
reed1
lgtm
5 years, 8 months ago (2015-04-15 20:04:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080923004/1
5 years, 8 months ago (2015-04-15 20:05:06 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 20:05:22 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/00b7e5eb973a1b1e4d1affa74fc0341e8c41e3da

Powered by Google App Engine
This is Rietveld 408576698