Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 1167013002: Fix OverscrollWindowDelegate to not dispatch superfluous OverscrollModeChange events (Closed)

Created:
5 years, 6 months ago by mfomitchev
Modified:
5 years, 6 months ago
Reviewers:
sadrul
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix OverscrollWindowDelegate to not dispatch superfluous OverscrollModeChange events Previously OverscrollWindowDelegate sometimes would call OnOverscrollModeChange on its delegate even if the overscroll mode didn't change. Specifically this happened for OVERSCROLL_NONE when an overscroll-cancelling condition such as a mouse move would occur. This could confuse OverscrollWindowAnimation and make it cancel the overscroll animation which shouldn't have been cancelled. On Windows there is currently a mouse event dispatched after each swipe on the touch screen, so this caused crbug.com/493672. BUG=493672 Committed: https://crrev.com/404f4d1ddaa75235e67a5f8a71ecc6ac8b2d65ec Cr-Commit-Position: refs/heads/master@{#333049}

Patch Set 1 #

Patch Set 2 : Unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M content/browser/web_contents/aura/overscroll_window_animation.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/aura/overscroll_window_delegate.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/web_contents/aura/overscroll_window_delegate_unittest.cc View 1 6 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mfomitchev
Sadrul, can you PTAL? This is needed for M44.
5 years, 6 months ago (2015-06-04 23:11:27 UTC) #2
sadrul
lgtm
5 years, 6 months ago (2015-06-05 14:26:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167013002/20001
5 years, 6 months ago (2015-06-05 14:28:00 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-05 15:36:15 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 15:37:13 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/404f4d1ddaa75235e67a5f8a71ecc6ac8b2d65ec
Cr-Commit-Position: refs/heads/master@{#333049}

Powered by Google App Engine
This is Rietveld 408576698