content/browser/web_contents/aura/overscroll_window_animation.cc - Issue 1167013002: Fix OverscrollWindowDelegate to not dispatch superfluous OverscrollModeChange events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/aura/overscroll_window_animation.cc

Issue 1167013002: Fix OverscrollWindowDelegate to not dispatch superfluous OverscrollModeChange events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unit test Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/aura/overscroll_window_animation.cc

diff --git a/content/browser/web_contents/aura/overscroll_window_animation.cc b/content/browser/web_contents/aura/overscroll_window_animation.cc

index 854a29934e499913ecec41c8a1cd8ca389a1f0c5..c89faa08b082c9a5db39f5a526bc66b838f9f2f0 100644

--- a/content/browser/web_contents/aura/overscroll_window_animation.cc

+++ b/content/browser/web_contents/aura/overscroll_window_animation.cc

@@ -86,6 +86,7 @@ void OverscrollWindowAnimation::OnImplicitAnimationsCompleted() {

void OverscrollWindowAnimation::OnOverscrollModeChange(

OverscrollMode old_mode,

OverscrollMode new_mode) {

+ DCHECK_NE(old_mode, new_mode);

Direction new_direction = GetDirectionForMode(new_mode);

if (new_direction == SLIDE_NONE) {

// The user cancelled the in progress animation.

« no previous file with comments | « no previous file | content/browser/web_contents/aura/overscroll_window_delegate.cc » ('j') | no next file with comments »