Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1166983007: Fix SurfaceLayerImpl scale under impl-side painting (Closed)

Created:
5 years, 6 months ago by enne (OOO)
Modified:
5 years, 6 months ago
Reviewers:
danakj, weiliangc, jbauman
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix SurfaceLayerImpl scale under impl-side painting With impl-side painting turned on (which is really property trees), Layer::CalculateContentsScale isn't run and Layer::PushPropertiesTo clobbers contents scale to 1.f, and content bounds to bounds. The problem was that the renderer would submit quads at scale=2 and the browser SurfaceLayerImpl would also see that it had a DSF would then scale its surface quad. To fix this, the SurfaceLayerImpl needs to apply the inverse scale of its surface when generating quads. Ideally, SurfaceAggregator could be changed in the future to just always unapply the DSF of the frame and reduce plumbing, but in the short term, this is a minimal change to ship impl-side painting. This change is similar to https://codereview.chromium.org/913243003. BUG=495142 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/c09eb94e92c8ca3698059eb471f71bb64acdf7b9 Cr-Commit-Position: refs/heads/master@{#333004}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix borders #

Patch Set 3 : Fix SLI test to set scale; remove SL test about content scale #

Total comments: 1

Patch Set 4 : Windows compile fix OOPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -48 lines) Patch
M cc/layers/surface_layer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/layers/surface_layer.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M cc/layers/surface_layer_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M cc/layers/surface_layer_impl.cc View 1 2 3 2 chunks +23 lines, -5 lines 0 comments Download
M cc/layers/surface_layer_impl_unittest.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M cc/layers/surface_layer_unittest.cc View 1 2 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
enne (OOO)
5 years, 6 months ago (2015-06-04 21:22:33 UTC) #4
danakj
LGTM https://codereview.chromium.org/1166983007/diff/1/cc/layers/surface_layer_impl.cc File cc/layers/surface_layer_impl.cc (right): https://codereview.chromium.org/1166983007/diff/1/cc/layers/surface_layer_impl.cc#newcode65 cc/layers/surface_layer_impl.cc:65: render_pass, content_bounds(), shared_quad_state, append_quads_data); i thin this should ...
5 years, 6 months ago (2015-06-04 21:25:18 UTC) #5
weiliangc
Thanks! LGTM
5 years, 6 months ago (2015-06-04 21:48:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166983007/20001
5 years, 6 months ago (2015-06-04 21:50:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/94899)
5 years, 6 months ago (2015-06-04 22:10:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166983007/20001
5 years, 6 months ago (2015-06-04 22:12:22 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/71930)
5 years, 6 months ago (2015-06-04 22:45:46 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166983007/40001
5 years, 6 months ago (2015-06-04 22:48:21 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/90702)
5 years, 6 months ago (2015-06-04 23:31:55 UTC) #20
danakj
https://codereview.chromium.org/1166983007/diff/40001/cc/layers/surface_layer_impl.cc File cc/layers/surface_layer_impl.cc (right): https://codereview.chromium.org/1166983007/diff/40001/cc/layers/surface_layer_impl.cc#newcode15 cc/layers/surface_layer_impl.cc:15: : LayerImpl(tree_impl, id), surface_id_(-1), surface_scale_(0.f) { surface_id is unsigned, ...
5 years, 6 months ago (2015-06-05 00:42:36 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166983007/10005
5 years, 6 months ago (2015-06-05 01:07:56 UTC) #24
commit-bot: I haz the power
Committed patchset #4 (id:10005)
5 years, 6 months ago (2015-06-05 03:43:24 UTC) #25
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 03:44:09 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c09eb94e92c8ca3698059eb471f71bb64acdf7b9
Cr-Commit-Position: refs/heads/master@{#333004}

Powered by Google App Engine
This is Rietveld 408576698