Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1639)

Issue 913243003: cc: Make HeadsUpDisplayLayer no longer a ContentsScalingLayer (Closed)

Created:
5 years, 10 months ago by enne (OOO)
Modified:
5 years, 10 months ago
Reviewers:
danakj
CC:
cc-bugs_chromium.org, chromium-reviews, vmpstr, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@painted_scrollbar_layer
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Make HeadsUpDisplayLayer no longer a ContentsScalingLayer The HUD layer can just get its scale from the compositor thread rather than the main thread. This change makes it possible to remove content scale calculations off of the main thread once TiledLayer is removed. Committed: https://crrev.com/73f6bd0f123b64ccd4f98d7fca237bbeb4604c83 Cr-Commit-Position: refs/heads/master@{#316248}

Patch Set 1 #

Total comments: 2

Patch Set 2 : ssssssssssssssssssssssssss #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -16 lines) Patch
M cc/layers/heads_up_display_layer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/heads_up_display_layer_impl.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M cc/layers/heads_up_display_layer_impl.cc View 1 11 chunks +22 lines, -13 lines 0 comments Download
M cc/layers/heads_up_display_layer_impl_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
enne (OOO)
Depends on https://codereview.chromium.org/913133004
5 years, 10 months ago (2015-02-11 23:41:35 UTC) #2
danakj
LGTM https://codereview.chromium.org/913243003/diff/1/cc/layers/heads_up_display_layer_impl.cc File cc/layers/heads_up_display_layer_impl.cc (right): https://codereview.chromium.org/913243003/diff/1/cc/layers/heads_up_display_layer_impl.cc#newcode129 cc/layers/heads_up_display_layer_impl.cc:129: internal_content_scale_ = draw_properties().ideal_contents_scale; nit: internal_contents_scale_ for inconsistent consistency? ...
5 years, 10 months ago (2015-02-11 23:47:48 UTC) #3
enne (OOO)
https://codereview.chromium.org/913243003/diff/1/cc/layers/heads_up_display_layer_impl.cc File cc/layers/heads_up_display_layer_impl.cc (right): https://codereview.chromium.org/913243003/diff/1/cc/layers/heads_up_display_layer_impl.cc#newcode129 cc/layers/heads_up_display_layer_impl.cc:129: internal_content_scale_ = draw_properties().ideal_contents_scale; On 2015/02/11 23:47:47, danakj wrote: > ...
5 years, 10 months ago (2015-02-12 00:03:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913243003/20001
5 years, 10 months ago (2015-02-13 17:46:36 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-13 18:56:10 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 18:56:50 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/73f6bd0f123b64ccd4f98d7fca237bbeb4604c83
Cr-Commit-Position: refs/heads/master@{#316248}

Powered by Google App Engine
This is Rietveld 408576698